Skip to content

[client] Add ability to preapre message, or use no JSON format. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

makasim
Copy link
Member

@makasim makasim commented Jan 19, 2018

fixes #316

@Koc
Copy link
Contributor

Koc commented Feb 22, 2018

What about providing serialization layer instead of extensions?

Create simple interface like this https://github.com/php-enqueue/enqueue-dev/blob/2b1094c3ff6db885cc999ce15291f598f352da6a/pkg/rdkafka/Serializer.php and ship lib with 2 serializers: json (simple, native like now) and Symfony's serializer.

@makasim
Copy link
Member Author

makasim commented Feb 22, 2018

It would introduce one extra concept, and it would be possible to achieve the goal with extensions. There might be an extension that supports Symfony serializer.

@makasim makasim closed this Aug 27, 2018
@makasim makasim deleted the client-normalize-message-extension-point branch August 27, 2018 11:25
@makasim
Copy link
Member Author

makasim commented Aug 30, 2018

closed in favor #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants